[MOB-11550] creates iterableEmbeddedMessageButton class#655
Merged
evantk91 merged 3 commits intoJun 24, 2025
Merged
Conversation
evantk91
changed the base branch from
master
to
evan/MOB-11549-iterable-embedded-metadata-class
|
❌ 4 blocking issues (4 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,61 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
| @@ -0,0 +1,61 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
| @@ -0,0 +1,91 @@ | |||
| import { IterableEmbeddedMessageElementsButton } from '../embedded/classes/IterableEmbeddedMessageElementsButton'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,40 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from '../embedded/classes/IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,61 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
lposen
reviewed
Jun 9, 2025
lposen
reviewed
Jun 9, 2025
lposen
reviewed
Jun 9, 2025
lposen
left a comment
lposen
left a comment
Contributor
There was a problem hiding this comment.
A few questions regarding the classes -- it seems to perhaps be unnecessarily complex.
Base automatically changed from
evan/MOB-11549-iterable-embedded-metadata-class
to
evan/feature/embedded
June 10, 2025 16:49
| @@ -0,0 +1,91 @@ | |||
| import { IterableEmbeddedMessageElementsButton } from '../embedded/classes/IterableEmbeddedMessageElementsButton'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,40 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from '../embedded/classes/IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,61 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
evantk91
changed the base branch from
evan/feature/embedded
to
evan/embedded-message-class
…le-embedded-message-button-class
| @@ -0,0 +1,91 @@ | |||
| import { IterableEmbeddedMessageElementsButton } from '../embedded/classes/IterableEmbeddedMessageElementsButton'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,40 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from '../embedded/classes/IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,61 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
| @@ -0,0 +1,91 @@ | |||
| import { IterableEmbeddedMessageElementsButton } from '../embedded/classes/IterableEmbeddedMessageElementsButton'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,40 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from '../embedded/classes/IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,61 @@ | |||
| import { IterableEmbeddedMessageElementsButtonAction } from './IterableEmbeddedMessageElementsButtonAction'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
evantk91
deleted the
evan/MOB-11550-iterable-embedded-message-button-class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description